Changeset 3672 in products for quintagroup.plonetabs/trunk/quintagroup/plonetabs/browser/plonetabs.py

Timestamp:

Apr 24, 2013 3:19:31 PM (11 years ago)

Author:

kroman0

Message:

Fixed 'PloneTabsControlPanel?.call' is too complex (11)

File:

• quintagroup.plonetabs/trunk/quintagroup/plonetabs/browser/plonetabs.py (modified) (14 diffs)

quintagroup.plonetabs/trunk/quintagroup/plonetabs/browser/plonetabs.py

@@ -77 +77 @@
         # action handler def handler(self, form)
         if submitted:
-            if 'add.add' in form.keys():
-                postback = self.manage_addAction(form, errors)
-            elif "edit.save" in form.keys():
-                postback = self.manage_editAction(form, errors)
-            elif "edit.delete" in form.keys():
-                postback = self.manage_deleteAction(form, errors)
-            elif "edit.moveup" in form.keys():
-                postback = self.manage_moveUpAction(form, errors)
-            elif "edit.movedown" in form.keys():
-                postback = self.manage_moveDownAction(form, errors)
-            elif "autogenerated.save" in form.keys():
-                postback = self.manage_setAutogeneration(form, errors)
-            else:
-                postback = True
+            postback = self.submitted_postback(form, errors)
 
         mode = self.request.get(cookie_name, False)
@@ -102 +89 @@
             return self.template(errors=errors)
 
+    def submitted_postback(self, form, errors):
+        """submitted postback"""
+        if 'add.add' in form.keys():
+            postback = self.manage_addAction(form, errors)
+        elif "edit.save" in form.keys():
+            postback = self.manage_editAction(form, errors)
+        elif "edit.delete" in form.keys():
+            postback = self.manage_deleteAction(form, errors)
+        elif "edit.moveup" in form.keys():
+            postback = self.manage_moveUpAction(form, errors)
+        elif "edit.movedown" in form.keys():
+            postback = self.manage_moveDownAction(form, errors)
+        elif "autogenerated.save" in form.keys():
+            postback = self.manage_setAutogeneration(form, errors)
+        else:
+            postback = True
+        return postback
+
+    @property
+    def plone_portal_state(self):
+        """plone_portal_state"""
+        return getMultiAdapter((aq_inner(self.context), self.request),
+                               name='plone_portal_state')
+
+    @property
+    def portal_properties(self):
+        """portal_properties"""
+        return getToolByName(self.context, 'portal_properties', None)
+
+    @property
+    def portal_actions(self):
+        """portal_actions"""
+        return getToolByName(self.context, 'portal_actions')
+
     ########################################
     # Methods for processing configlet posts
@@ -110 +131 @@
 
         # set excludeFromNav property for root objects
-        portal = getMultiAdapter((aq_inner(self.context), self.request),
-                                 name='plone_portal_state').portal()
+        portal = self.plone_portal_state.portal()
         generated_tabs = form.get("generated_tabs", '0')
         nonfolderish_tabs = form.get("nonfolderish_tabs", '0')
@@ -257 +277 @@
         """Redirect to @@plonetabs-controlpanel configlet"""
         if not url:
-            portal_url = getMultiAdapter(
-                (self.context, self.request),
-                name=u"plone_portal_state").portal_url()
+            portal_url = self.plone_portal_state.portal_url()
             url = '%s/%s' % (portal_url, "@@plonetabs-controlpanel")
         if search:
@@ -274 +292 @@
 
     def _charset(self):
-        pp = getToolByName(self.context, 'portal_properties', None)
+        pp = self.portal_properties
         if pp is not None:
             site_properties = getattr(pp, 'site_properties', None)
@@ -283 +301 @@
     def getPageTitle(self, category="portal_tabs"):
         """See interface"""
-        portal_props = getToolByName(self.context, "portal_properties")
+        portal_props = self.portal_properties
         default_title = _(u"Plone '${cat_name}' Configuration",
                           mapping={'cat_name': category})
@@ -312 +330 @@
     def hasActions(self, category="portal_tabs"):
         """See interface"""
-        tool = getToolByName(self.context, "portal_actions")
+        tool = self.portal_actions
         return len(tool.listActions(categories=[category, ])) > 0
 
     def getPortalActions(self, category="portal_tabs"):
         """See interface"""
-        portal_actions = getToolByName(self.context, "portal_actions")
+        portal_actions = self.portal_actions
 
         if category not in portal_actions.objectIds():
@@ -331 +349 @@
     def isGeneratedTabs(self):
         """See interface"""
-        site_properties = getToolByName(self.context,
-                                        "portal_properties").site_properties
+        site_properties = self.portal_properties.site_properties
         return not site_properties.getProperty("disable_folder_sections",
                                                False)
@@ -338 +355 @@
     def isNotFoldersGenerated(self):
         """See interface"""
-        site_properties = getToolByName(self.context,
-                                        "portal_properties").site_properties
+        site_properties = self.portal_properties.site_properties
         prop = site_properties.getProperty("disable_nonfolderish_sections",
                                            False)
@@ -364 +380 @@
 
         portal_catalog = getToolByName(context, 'portal_catalog')
-        portal_properties = getToolByName(context, 'portal_properties')
+        portal_properties = self.portal_properties
         navtree_properties = getattr(portal_properties, 'navtree_properties')
 
@@ -407 +423 @@
         for item in rawresult:
             if item.getId not in excludedIds:
-                id, item_url = get_view_url(item)
-                data = {'name': utils.pretty_title_or_id(context, item),
-                        'id': id,
-                        'url': item_url,
-                        'description': item.Description,
-                        'exclude_from_nav': item.exclude_from_nav}
-                result.append(data)
+                result.append(self.getItem(item))
 
         return result
+
+    def getItem(self, item):
+        """get item"""
+        context = aq_inner(self.context)
+        id_, item_url = get_view_url(item)
+        data = {
+            'name': utils.pretty_title_or_id(context, item),
+            'id': id_,
+            'url': item_url,
+            'description': item.Description,
+            'exclude_from_nav': item.exclude_from_nav,
+        }
+        return data
 
     def getCategories(self):
         """See interface"""
-        portal_actions = getToolByName(self.context, "portal_actions")
+        portal_actions = self.portal_actions
         return portal_actions.objectIds()
 
@@ -557 +580 @@
     def kss_toggleRootsVisibility(self, id, checked='0'):
         """Toggle visibility for portal root objects (exclude_from_nav)"""
-        portal = getMultiAdapter((aq_inner(self.context), self.request),
-                                 name='plone_portal_state').portal()
+        portal = self.plone_portal_state.portal()
 
         # remove prefix, added for making ids on configlet unique ("roottabs_")
@@ -973 +995 @@
 
     def getActionCategory(self, name):
-        portal_actions = getToolByName(self.context, 'portal_actions')
+        portal_actions = self.portal_actions
         return portal_actions[name]
 
     def getOrCreateCategory(self, name):
         """Get or create (if necessary) category"""
-        portal_actions = getToolByName(self.context, 'portal_actions')
+        portal_actions = self.portal_actions
         if name not in map(lambda x: x.id,
                            filter(lambda x: IActionCategory.providedBy(x),
@@ -987 +1009 @@
     def setSiteProperties(self, **kw):
         """Change site_properties"""
-        site_properties = getToolByName(self.context,
-                                        "portal_properties").site_properties
+        site_properties = self.portal_properties.site_properties
         site_properties.manage_changeProperties(**kw)
         return True