Changeset 3339 in products for quintagroup.dropdownmenu/trunk/quintagroup/dropdownmenu/browser/viewlets.py

Timestamp:

Jan 26, 2012 2:50:56 PM (12 years ago)

Author:

chervol

Message:

caching of the dropdownmenu revisited

File:

• quintagroup.dropdownmenu/trunk/quintagroup/dropdownmenu/browser/viewlets.py (modified) (3 diffs)

quintagroup.dropdownmenu/trunk/quintagroup/dropdownmenu/browser/viewlets.py

@@ -23 +23 @@
 import copy
 
-
 def menu_cache_key(f, view):
+    # menu cache key conssits of:
+    # - selected item not only top tab
+    # - site can beaccessed on different domains 
+    # - language is important for multilingua sites
+
     portal_state = getMultiAdapter((view.context, view.request),
                                    name=u'plone_portal_state')
@@ -31 +35 @@
     if view.conf.content_tabs_level > 0:
         content_path = content_path[:view.conf.content_tabs_level]
-    path_key = '/'.join(content_path)
+    path_key = view.request.physicalPathToURL(content_path)
+
+    language = portal_state.locale().getLocaleID()
+
+    # Cache for five minutes. Note that the HTTP RAM-cache
+    # typically purges entries after 60 minutes.
     return view.__name__ + \
            path_key + \
-           str(time() // (60 * 5))  # Every five minutes
-                                    # Note that the HTTP RAM-cache
-                                    # typically purges entries after
-                                    # 60 minutes.
-
-
+           language + \
+           str(time() // (60 * 5))  
+
+# we are gcaching the menu structure built out of portal_actions tool
+# this cache key does not take in account expressions and roles settings
 def tabs_cache_key(f, view, site_url):
     return site_url + str(time() // (60 * 60))
 
-
 def dropdowncache(f):
     def func(view):
-        if view.conf.show_actions_tabs:
+        portal_state = getMultiAdapter((view.context, view.request),
+                                        name=u'plone_portal_state')
+        # it is impossible to reliably cache entire rendered menu generated  
+        # with potral actions strategy.
+        if not view.conf.enable_caching or view.conf.show_actions_tabs or \
+           (not portal_state.anonymous() and \
+                view.conf.caching_strategy == 'anonymous'):
             return f(view)
         return ram.cache(menu_cache_key)(f)(view)
@@ -55 +68 @@
     index = ViewPageTemplateFile('templates/sections.pt')
     recurse = ViewPageTemplateFile('templates/sections_recurse.pt')
+
 
     def update(self):