Changeset 3117 in products for quintagroup.plonecomments/trunk/quintagroup/plonecomments/utils.py

Timestamp:

Apr 14, 2011 5:49:27 PM (13 years ago)

Author:

kroman0

Message:

Pyflakes and pep8 fixes #4

File:

• quintagroup.plonecomments/trunk/quintagroup/plonecomments/utils.py (modified) (10 diffs)

quintagroup.plonecomments/trunk/quintagroup/plonecomments/utils.py

@@ -42 +42 @@
 
     prop_sheet = context.portal_properties['qPloneComments']
-    props = filter(lambda x: prop_sheet.getProperty(x), prop_sheet.propertyIds())
+    props = filter(lambda x: prop_sheet.getProperty(x), \
+                   prop_sheet.propertyIds())
 
     actions = {
@@ -86 +87 @@
                 [obj.Creator(), ]
             userid = creators and creators[0] or ""
-            creator = getToolByName(context, 'portal_membership').getMemberById(userid)
+            portal_membership = getToolByName(context, 'portal_membership')
+            creator = portal_membership.getMemberById(userid)
             if creator and allowEmail(context, reply, state, creator):
                 return creator.getProperty('email', '')
@@ -105 +107 @@
     def getParentOwnerEmail(reply, context):
         creator_id = getParent(reply).getOwnerTuple()[1]
-        creator = getToolByName(context, 'portal_membership').getMemberById(creator_id)
+        portal_membership = getToolByName(context, 'portal_membership')
+        creator = portal_membership.getMemberById(creator_id)
         if creator and allowEmail(context, reply, state, creator):
             return creator.getProperty('email', '')
@@ -117 +120 @@
     organization_name = getProp(context, 'email_subject_prefix', '')
     creator_name = reply.getOwnerTuple()[1]
-    admin_email = context.portal_url.getPortalObject().getProperty('email_from_address')
+    portal = getToolByName(context, 'portal_url').getPortalObject()
+    admin_email = portal.getProperty('email_from_address')
     translate = getToolByName(context, 'translation_service').translate
     subject = ''
@@ -123 +127 @@
         subject = translate(_(u"approve_user_notification_subject",
             default=u"Your comment on ${title} is now published",
-            mapping={u"title": safe_unicode(getParent(context).title_or_id())}),
+            mapping={u"title":
+                safe_unicode(getParent(context).title_or_id())}),
             context=context.REQUEST)
         if user_email:
@@ -138 +143 @@
         subject = translate(_(u"rejected_user_notification_subject",
             default=u"Your comment on ${title} was not approved",
-            mapping={u"title": safe_unicode(getParent(context).title_or_id())}),
+            mapping={u"title":
+                safe_unicode(getParent(context).title_or_id())}),
             context=context.REQUEST)
         if user_email:
@@ -154 +160 @@
         subject = translate(_(u"reply_user_notification_subject",
             default=u"Someone replied to your comment on ${title}",
-            mapping={u"title": safe_unicode(getParent(context).title_or_id())}),
+            mapping={u"title":
+                safe_unicode(getParent(context).title_or_id())}),
             context=context.REQUEST)
         di_parrent = getDIParent(reply)
@@ -200 +207 @@
             args = {}
 
-    elif state in ('enable_authenticated_report_abuse', 'enable_anonymous_report_abuse'):
+    elif state in ('enable_authenticated_report_abuse',
+                   'enable_anonymous_report_abuse'):
         template = 'report_abuse_template'
         user_email = getProp(context, "email_discussion_manager", None)
@@ -230 +238 @@
     if args:
         msg = getMsg(context, template, args)
-        charset = context.portal_properties.site_properties.getProperty('default_charset', 'utf-8')
+        site_properties = context.portal_properties.site_properties
+        charset = site_properties.getProperty('default_charset', 'utf-8')
         msg = msg.encode(charset)
         host = context.plone_utils.getMailHost()
@@ -236 +245 @@
             host.secureSend(msg, user_email, admin_email, subject=subject,
                             subtype='plain', debug=False, charset=charset)
-        except (smtplib.SMTPRecipientsRefused,smtplib.SMTPServerDisconnected):
+        except (smtplib.SMTPRecipientsRefused, smtplib.SMTPServerDisconnected):
             setStatusMsg(None, context,
                 _('Could not send the email notification. Have you configured an email server for Plone?'))