Changeset 2902 in products for quintagroup.seoptimizer/branches/plone4/quintagroup/seoptimizer/tests/testUsageKeywords.py

Timestamp:

Oct 20, 2010 1:35:24 PM (14 years ago)

Author:

mylan

Message:

Fix for #28 issue (​http://plone.org/products/plone-seo/issues/28) merged
into plone4 branch.

Merged revisions 3924,3927-3929,3933-3934,3939-3940 via svnmerge from
​http://svn.quintagroup.com/products/quintagroup.seoptimizer/trunk

........

r3924 | mylan | 2010-10-19 15:09:28 +0300 (Tue, 19 Oct 2010) | 1 line

#233: Updated configlet tests for new external_configlet_test checkbox

........

r3927 | mylan | 2010-10-19 17:05:55 +0300 (Tue, 19 Oct 2010) | 1 line

#233: Fixed 'external_keywords_test' option tests in configlet, refs #233

........

r3928 | mylan | 2010-10-19 17:09:37 +0300 (Tue, 19 Oct 2010) | 1 line

Added 'external_keywords_test' option to configlet, refs #233

........

r3929 | mylan | 2010-10-19 17:12:18 +0300 (Tue, 19 Oct 2010) | 1 line

#233: removed some debugging code

........

r3933 | mylan | 2010-10-19 20:48:19 +0300 (Tue, 19 Oct 2010) | 1 line

#233: Added tests for calculation keywords

........

r3934 | mylan | 2010-10-19 20:52:01 +0300 (Tue, 19 Oct 2010) | 1 line

#233: Updated keywords calculation - replace lynx usage with portal_transforms, added optional external page retrieval

........

r3939 | mylan | 2010-10-20 16:10:45 +0300 (Wed, 20 Oct 2010) | 1 line

#233: Updated tests for correct errors handling in keyword check view

........

r3940 | mylan | 2010-10-20 16:14:13 +0300 (Wed, 20 Oct 2010) | 1 line

#233: Check SEO keywords: Added error handling, return reasonable info in case of error

........

Location:

quintagroup.seoptimizer/branches/plone4

Files:

• . (modified) (2 props)
• quintagroup/seoptimizer/tests/testUsageKeywords.py (modified) (2 diffs)

quintagroup.seoptimizer/branches/plone4

@@ -1 +1 @@
 /quintagroup.seoptimizer/branches/refactoring2.3.0:1776-2133
-/quintagroup.seoptimizer/trunk:2435-2440
+/quintagroup.seoptimizer/trunk:2435-2440,2885-2901

@@ -1 +1 @@
 /quintagroup.seoptimizer/branches/refactoring2.3.0:1776-2133
-/quintagroup.seoptimizer/trunk:2435-2440
+/quintagroup.seoptimizer/trunk:2435-2440,2885-2901

quintagroup.seoptimizer/branches/plone4/quintagroup/seoptimizer/tests/testUsageKeywords.py

@@ -1 +1 @@
 from base import *
+import urllib2
+from StringIO import StringIO
+from zope.component import queryMultiAdapter
+from zope.interface import alsoProvides
+from quintagroup.seoptimizer.browser.interfaces import IPloneSEOLayer
 
 KWSTMPL = '.*(<meta\s+(?:(?:name="keywords"\s*)|(?:content="%s"\s*)){2}/>)'
@@ -59 +64 @@
 
 
+class TestCalcKeywords(FunctionalTestCase):
+
+    def afterSetUp(self):
+        self.loginAsPortalOwner()
+        self.seo = self.portal.portal_properties.seo_properties
+        #Preparation for functional testing
+        self.key = "SEO_KEYWORD "
+        self.portal.invokeFactory('Document', id='my_doc')
+        self.my_doc = getattr(self.portal, 'my_doc')
+        self.my_doc.setText(self.key * 2)
+        # Emulate JS request
+        self.app.REQUEST.set("text", self.key)
+        # Mark request with IPloneSEOLayer browser layer interface
+        alsoProvides(self.app.REQUEST, IPloneSEOLayer)
+        # Get checkSEOKeywords view
+        self.chckView = queryMultiAdapter((self.my_doc, self.app.REQUEST),
+            name="checkSEOKeywords")
+        
+    def patchURLLib(self, fnc):
+        self.orig_urlopen = urllib2.urlopen
+        self.urlfd = StringIO()
+        urllib2.urlopen = fnc
+    
+    def unpatchURLLib(self):
+        urllib2.urlopen = self.orig_urlopen
+        self.urlfd.close()
+
+    def test_InternalPageRendering(self):
+        self.assertTrue(not self.seo.external_keywords_test)
+        # Only keywords from content must present in check view
+        self.assertTrue('2' in self.chckView())
+
+    def test_ExternalPageRendering(self):
+        def patch_urlopen(*args, **kwargs):
+            if args[0] == self.my_doc.absolute_url():
+                self.urlfd.write(unicode(self.my_doc() + self.key).encode("utf-8"))
+                self.urlfd.seek(0)
+                return self.urlfd
+            else:
+                return self.orig_urlopen(*args, **kwargs)
+        self.seo._updateProperty("external_keywords_test", True)
+        self.patchURLLib(fnc=patch_urlopen)
+        self.assertTrue(self.seo.external_keywords_test)
+        # 1. Extra keyword must present in check view
+        self.assertTrue('3' in self.chckView())
+        # 2. Opened urllib file descriptor must be closed
+        self.assertTrue(self.urlfd.closed, "Opened file descriptor was not closed.")
+        self.unpatchURLLib()
+        
+    def test_ExternalURLError(self):
+        def patch_urlopen(*args, **kwargs):
+            if args[0] == self.my_doc.absolute_url():
+                raise urllib2.URLError("Some URL Error occured")
+            else:
+                return self.orig_urlopen(*args, **kwargs)
+        self.seo._updateProperty("external_keywords_test", True)
+        self.patchURLLib(fnc=patch_urlopen)
+        self.assertTrue(self.seo.external_keywords_test)
+        # 1. Information about problem must present in check view
+        self.assertTrue("Problem with page retrieval" in self.chckView())
+        # 2. Opened urllib file descriptor should not be closed because
+        #    it even not returned to the view
+        self.assertFalse(self.urlfd.closed, "Opened file descriptor was closed.")
+        self.unpatchURLLib()
+    
+    def test_ExternalIOError(self):
+        def patch_urlopen(*args, **kwargs):
+            if args[0] == self.my_doc.absolute_url():
+                self.urlfd.write(unicode(self.my_doc() + self.key).encode("utf-8"))
+                self.urlfd.seek(0)
+                return self.urlfd
+            else:
+                return self.orig_urlopen(*args, **kwargs)
+        def patch_read(*args, **kwargs):
+            raise IOError()
+        # Patch urllib2.urlopen to emulate external url retrieval
+        self.patchURLLib(fnc=patch_urlopen)
+        # Patch opened by urllib2 file descriptor to emulate IOError during reading
+        self.urlfd.read = patch_read
+        self.seo._updateProperty("external_keywords_test", True)
+        self.assertTrue(self.seo.external_keywords_test)
+        # 1. Information about problem must present in check view
+        self.assertTrue("Problem with page retrieval" in self.chckView())
+        # 2. Opened urllib file descriptor must be closed
+        self.assertTrue(self.urlfd.closed, "Opened file descriptor was not closed.")
+        self.unpatchURLLib()
+        
+
 def test_suite():
     from unittest import TestSuite, makeSuite
     suite = TestSuite()
     suite.addTest(makeSuite(TestUsageKeywords))
+    suite.addTest(makeSuite(TestCalcKeywords))
     return suite
+

@@ -1 +1 @@
 /quintagroup.seoptimizer/branches/refactoring2.3.0:1776-2133
-/quintagroup.seoptimizer/trunk:2435-2440
+/quintagroup.seoptimizer/trunk:2435-2440,2885-2901