Changeset 1890 in products for quintagroup.seoptimizer/branches/refactoring2.3.0/quintagroup/seoptimizer/tests/testResponse.py

Timestamp:

Mar 11, 2010 3:51:07 PM (14 years ago)

Author:

mylan

Message:

#161: Clarify and simplify testResponse tests

File:

• quintagroup.seoptimizer/branches/refactoring2.3.0/quintagroup/seoptimizer/tests/testResponse.py (modified) (7 diffs)

quintagroup.seoptimizer/branches/refactoring2.3.0/quintagroup/seoptimizer/tests/testResponse.py

@@ -15 +15 @@
 ]
 
-FORM_DATA = {
+FORM = {
     'seo_robots': 'ALL',
     'form.submitted:int': 1,
@@ -31 +31 @@
     'seo_description': 'it is description, test keyword1',
 }
+
+METATAG = '.*(<meta\s+(?:(?:name="%s"\s*)|(?:content="%s"\s*)){2}/>)'
 
 class TestResponse(FunctionalTestCase):
@@ -58 +60 @@
         self.publish(path=self.abs_path+'/@@seo-context-properties',
                      basic=self.basic_auth, request_method='POST',
-                     stdin=StringIO(urllib.urlencode(FORM_DATA)+st))
+                     stdin=StringIO(urllib.urlencode(FORM)+st))
         self.wf.doActionFor(my_doc, 'publish')
         # get html view of test document
@@ -73 +75 @@
         """
         # setup page with title equal to plone site's title
-        my_doc2 = self.portal.invokeFactory('Document', id='my_doc2', title=self.portal.Title())
+        my_doc2 = self.portal.invokeFactory('Document', id='my_doc2',
+                                            title=self.portal.Title())
         my_doc2 = self.portal['my_doc2']
         self.wf.doActionFor(my_doc2, 'publish')
@@ -82 +85 @@
 
     def testDescription(self):
-        m = re.match('.*(<meta\s+(?:(?:name="description"\s*)|(?:content="it is description, test keyword1"\s*)){2}/>)', self.html, re.S|re.M)
+        m = re.match(METATAG % ("description", FORM['seo_description']), self.html, re.S|re.M)
         self.assert_(m, 'Description not set in')
 
     def testRobots(self):
-        m = re.match('.*(<meta\s+(?:(?:name="robots"\s*)|(?:content="ALL"\s*)){2}/>)', self.html, re.S|re.M)
+        m = re.match(METATAG % ("robots", FORM['seo_robots']), self.html, re.S|re.M)
         self.assert_(m, 'Robots not set in')
 
     def testDistribution(self):
-        m = re.match('.*(<meta\s+(?:(?:name="distribution"\s*)|(?:content="Global"\s*)){2}/>)', self.html, re.S|re.M)
+        m = re.match(METATAG % ("distribution", FORM['seo_distribution']), self.html, re.S|re.M)
         self.assert_(m, 'Distribution not set in')
 
@@ -98 +101 @@
 
     def testTagsOrder(self):
+        def is_match(html, mtorder):
+            return re.search('.*'.join(['<meta.*name="%s".*/>' %t \
+                                        for t in mtorder]), html, re.S|re.M)
+
         metatags_order = [t for t in self.sp.getProperty('metatags_order') if t in VIEW_METATAGS]
-        m = re.search('.*'.join(['<meta.*name="%s".*/>' %t for t in metatags_order]), self.html, re.S|re.M)
-        self.assert_(m, "Meta tags order not supported.")
+        self.assert_(is_match(self.html, metatags_order), "Meta tags order not supported.")
 
         metatags_order.reverse()
-        m = re.search('.*'.join(['<meta.*name="%s".*/>' %t for t in metatags_order]), self.html, re.S|re.M)
-        self.assertFalse(m, "Meta tags order not supported.")
+        self.assertFalse(is_match(self.html, metatags_order), "Meta tags order not supported.")
 
-        self.sp.manage_changeProperties(**{'metatags_order':metatags_order})
+        self.sp.manage_changeProperties(metatags_order = metatags_order)
+        self.assertFalse(is_match(self.html, metatags_order), "Meta tags order not supported.")
+
         html = self.publish(self.abs_path, self.basic_auth).getBody()
-        m = re.search('.*'.join(['<meta.*name="%s".*/>' %t for t in metatags_order]), self.html, re.S|re.M)
-        self.assertFalse(m, "Meta tags order not supported.")
-
-        m = re.search('.*'.join(['<meta.*name="%s".*/>' %t for t in metatags_order]), html, re.S|re.M)
-        self.assert_(m, "Meta tags order not supported.")
+        self.assert_(is_match(html, metatags_order), "Meta tags order not supported.")
 
 
     def testCustomMetaTags(self):
         for tag in CUSTOM_METATAGS:
-            m = re.match('.*(<meta\s+(?:(?:name="%(meta_name)s"\s*)|(?:content="%(meta_content)s"\s*)){2}/>)' % tag, self.html, re.S|re.M)
+            m = re.match(METATAG % (tag['meta_name'], tag['meta_content']),
+                         self.html, re.S|re.M)
             if tag['meta_content']:
                 self.assert_(m, "Custom meta tag %s not applied." % tag['meta_name'])
             else:
-                self.assert_(not m, "Meta tag %s has no content, but is present in the page." % tag['meta_name'])
-        m = re.match('.*(<meta\s+(?:(?:name="metatag4"\s*)|(?:content="global_metatag4value"\s*)){2}/>)', self.html, re.S|re.M)
+                self.assert_(not m, "Meta tag %s has no content, but is present:" \
+                                 " in the page." % tag['meta_name'])
+
+        m = re.match(METATAG % ("metatag4", "global_metatag4value"), self.html, re.S|re.M)
         self.assert_(m, "Global custom meta tag %s not applied." % 'metatag4')
 
     def testDeleteCustomMetaTags(self):
-        self.sp.manage_changeProperties(**{'default_custom_metatags':'metatag1|global_metatag1value'})
+        self.sp.manage_changeProperties(
+            default_custom_metatags = 'metatag1|global_metatag1value')
         form_data = {'seo_custommetatags': CUSTOM_METATAGS,
                      'seo_custommetatags_override:int': 0,
@@ -133 +140 @@
                      basic=self.basic_auth, request_method='POST',
                      stdin=StringIO(urllib.urlencode(form_data)))
-        self.html = self.publish(self.abs_path, self.basic_auth).getBody()
-        m = re.match('.*(<meta\s+(?:(?:name="metatag4"\s*)|(?:content="global_metatag4value"\s*)){2}/>)', self.html, re.S|re.M)
+        html = self.publish(self.abs_path, self.basic_auth).getBody()
+
+        m = re.match(METATAG % ("metatag4", "global_metatag4value"), html, re.S|re.M)
         self.assert_(not m, "Global custom meta tag %s is prosent in the page." % 'metatag4')
-        m = re.match('.*(<meta\s+(?:(?:name="metatag1"\s*)|(?:content="global_metatag1value"\s*)){2}/>)', self.html, re.S|re.M)
+
+        m = re.match(METATAG % ("metatag1", "global_metatag1value"), html, re.S|re.M)
         self.assert_(m, "Global custom meta tag %s not applied." % 'metatag1')