Changeset 1177

Timestamp:

07/25/08 05:13:06

Author:

piv

Message:

refactored acton deletion, some minor fixes

Files:

• qPloneTabs/branches/quintagroup.plonetabs/trunk/quintagroup/plonetabs/browser/kssactions.zcml (modified) (1 diff)
• qPloneTabs/branches/quintagroup.plonetabs/trunk/quintagroup/plonetabs/browser/plonetabs.py (modified) (12 diffs)
• qPloneTabs/branches/quintagroup.plonetabs/trunk/quintagroup/plonetabs/browser/templates/actionslist.pt (modified) (1 diff)

qPloneTabs/branches/quintagroup.plonetabs/trunk/quintagroup/plonetabs/browser/kssactions.zcml

@@ -29 +29 @@
-    <browser:page
-        for="plone.app.kss.interfaces.IPortalObject"
-
+kss_
-        class=".plonetabs.PloneTabsControlPanel"
-        name="plonetabs-deleteAction"

qPloneTabs/branches/quintagroup.plonetabs/trunk/quintagroup/plonetabs/browser/plonetabs.py

@@ -30 +30 @@
-from interfaces import IPloneTabsControlPanel
-
-visible", "url_expr", "title", "available_expr
+title", "url_expr", "available_expr", "visible
-
-class PloneTabsControlPanel(PloneKSSView):
@@ -115 +115 @@
-    
-    def manage_addAction(self, form, errs):
-
+
+
-        cat_name = form['category']
-        
-
-
-
+
+
-        
-        # if not errors find (or create) category and set action to it
@@ -134 +134 @@
-    
-    def manage_editAction(self, form, errs):
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
-    
-    def manage_moveUpAction(self, form, errors):
@@ -295 +234 @@
-        self.request.response.redirect("%s%s%s" % (url, search, hash))
-    
-    
-    ###################################
-
+
+
+
-    ###################################
-    
@@ -419 +359 @@
-        return portal_actions.objectIds()
-    
+    #
+    # Methods to make this class looks like global sections viewlet
+    #
+    
-    def test(self, condition, ifTrue, ifFalse):
-        """ See interface """
@@ -444 +388 @@
-    
-    ##########################
-
+
+
+
-    ##########################
-    
@@ -531 +477 @@
-    
-    @kssaction
-
+kss_
-        """ Delete portal action with given id & category """
-        portal_actions = getToolByName(self.context, "portal_actions")
@@ -584 +530 @@
-        ksscore.replaceHTML(ksscore.getHtmlIdSelector(replace_id), content)
-    
+    #
-    # Utility Methods
+    #
-    
-    def copyAction(self, action):
@@ -593 +541 @@
-        return action_info
-    
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+
-        """ Check action fields on validity """
-        errors = {}
-        
-
-
-
+
+
+
+
-        
-        # validate action id
@@ -630 +559 @@
-        # validate action name
-        if not data['title'].strip():
-id
+title
-        
-        # validate condition expression
@@ -648 +577 @@
-        return errors
-    
+    def processErrors(self, errors, prefix='', sufix=''):
+        """ Add prefixes, sufixes to error ids 
+            This is necessary during edit form validation,
+            because every edit form on the page has it's own sufix (id) """
+        if not (prefix or sufix):
+            return errors
+        
+        result = {}
+        for key, value in errors.items():
+            result['%s%s%s' % (prefix, key, sufix)] = value
+        
+        return result
+    
+    def parseForm(self, form):
+        """ Extract all needed fields """
+        # get original id and category
+        info = {}
+        id = form['orig_id']
+        category = form['category']
+        
+        # preprocess 'visible' field (checkbox needs special checking)
+        if form.has_key('visible_%s' % id):
+            form['visible_%s' % id] = True
+        else:
+            form['visible_%s' % id] = False
+        
+        # collect all action fields
+        for attr in ACTION_ATTRS:
+            info[attr] = form['%s_%s' % (attr, id)]
+        
+        return (id, category, info)
+    
+    def getActionCategory(self, name):
+        portal_actions = getToolByName(self.context, 'portal_actions')
+        return portal_actions[name]
+    
-    def getOrCreateCategory(self, name):
+        """ Get or create (if necessary) category """
-        portal_actions = getToolByName(self.context, 'portal_actions')
-        if name not in map(lambda x: x.id, filter(lambda x: IActionCategory.providedBy(x), portal_actions.objectValues())):
-            portal_actions._setObject(name, ActionCategory(name))
-
-
-
-
+
-    
-    def addAction(self, cat_name, data):
-        """ Create and add new action to category with given name """
-        
-        # get or create category if it's necessary
-        id = data.pop('id')
-        category = self.getOrCreateCategory(cat_name)
-        
-        # add action
-        action = Action(id, **data)
-        category._setObject(id, action)
-        return action
-    
+    def updateAction(self, id, cat_name, data):
+        """ Update action with given id and category """
+        new_id = data.pop('id')
+        category = self.getActionCategory(cat_name)
+        
+        # rename action if necessary
+        if id != new_id:
+            category.manage_renameObject(id, new_id)
+        
+        # get action
+        action = category[new_id]
+        
+        # update action properties
+        for attr in ACTION_ATTRS:
+            if data.has_key(attr):
+                action._setPropValue(attr, data[attr])
+        
+        return action
+    
+    def deleteAction(self, id, cat_name):
+        """ Delete action with given id from given category """
+        category = self.getActionCategory(cat_name)
+        category.manage_delObjects(ids=[id,])
+        return True
+    
+    #
-    # KSS Methods that are used to update different parts of the page
-    # according to category
+    #
-    
-    def updatePage(self, category):
@@ -705 +691 @@
-
-
-
-
-
-
-
-
-
-
-

qPloneTabs/branches/quintagroup.plonetabs/trunk/quintagroup/plonetabs/browser/templates/actionslist.pt

@@ -35 +35 @@
-      <input type="checkbox" class="visibility" value="1" name="visible" title="visibility"
-             tal:define="name string:${attrs/name}_${id};
-
-
-
-
+
+
+
-    </div>
-