Changeset 3403 in products for quintagroup.plonetabs/branches/tests/quintagroup/plonetabs/tests

Timestamp:

Apr 3, 2012 11:40:34 AM (12 years ago)

Author:

potar

Message:

Fixed code according with pylint, pyflakes

Location:

quintagroup.plonetabs/branches/tests/quintagroup/plonetabs/tests

Files:

• base.py (modified) (1 diff)
• selenium/zopeconfig.py (modified) (1 diff)
• test_controlpanel.py (modified) (4 diffs)
• test_erase.py (modified) (2 diffs)
• test_setup.py (modified) (2 diffs)

quintagroup.plonetabs/branches/tests/quintagroup/plonetabs/tests/base.py

@@ -8 +8 @@
 from  Testing import ZopeTestCase as ztc
 from  Products.Five import zcml
-from  Products.Five import fiveconfigure
 from Products.CMFCore.utils import getToolByName
-from Products.CMFCore.interfaces import IAction, IActionCategory
 from Products.CMFCore.ActionInformation import Action, ActionCategory
 from  Products.PloneTestCase import PloneTestCase as ptc

quintagroup.plonetabs/branches/tests/quintagroup/plonetabs/tests/selenium/zopeconfig.py

@@ -4 +4 @@
     KSSSeleniumTestCase
 
-from plone.app.kss.demo.zopeconfig import PloneSiteLayer, \
-    LoggedInManagerLayer, LoggedInUserLayer, IResource
+from plone.app.kss.demo.zopeconfig import LoggedInManagerLayer, IResource
 
 

quintagroup.plonetabs/branches/tests/quintagroup/plonetabs/tests/test_controlpanel.py

@@ -6 +6 @@
 
 from Products.CMFCore.utils import getToolByName
-from Products.CMFCore.ActionInformation import Action, ActionCategory
+from Products.CMFCore.ActionInformation import Action
 
 from quintagroup.plonetabs import messageFactory as _
@@ -73 +73 @@
         # Revert PloneTestCase's optimization
         # because this breaks our test
+        #### pyflakes.scripts.pyflakes, modified:
+        ## - return array of warnings instead of printing them
+        ## - honour pyflakes:ignore comments
         def __init__(self, text):
             self.text = text
@@ -78 +81 @@
                 self._v_compiled = getEngine().compile(text)
         from Products.CMFCore.Expression import Expression
+
         optimized__init__ = Expression.__init__
         Expression.__init__ = __init__
@@ -86 +90 @@
         self.assertEquals(len(errors.keys()), 4,
             'validateActionFields method is not working properly.')
+        #### pyflakes.scripts.pyflakes ends.
 
     def test_processErrors(self):

quintagroup.plonetabs/branches/tests/quintagroup/plonetabs/tests/test_erase.py

@@ -6 +6 @@
 from Testing import ZopeTestCase as ztc
 
-from zope.component import getSiteManager
 from zope.app.component.hooks import setHooks, setSite
 
@@ -108 +107 @@
 
     def test_browserLayer(self):
-        sm = getSiteManager(self.portal)
         layers = [o.__name__ for o in registered_layers()]
         self.failIf('IPloneTabsProductLayer' in layers,

quintagroup.plonetabs/branches/tests/quintagroup/plonetabs/tests/test_setup.py

@@ -1 +1 @@
 import unittest
-
-from zope.component import getSiteManager
 
 from plone.browserlayer.utils import registered_layers
@@ -71 +69 @@
 
     def test_browserLayerRegistered(self):
-        sm = getSiteManager(self.portal)
         layers = [o.__name__ for o in registered_layers()]
         self.failUnless('IPloneTabsProductLayer' in layers,