Changeset 3159 in products

Timestamp:

Apr 20, 2011 10:39:13 AM (13 years ago)

Author:

mylan

Message:

Prevent replacing existent objects on reinstallation package, updated comments

File:

• ploneorg.kudobounty/trunk/ploneorg/kudobounty/setuphandlers.py (modified) (4 diffs)

ploneorg.kudobounty/trunk/ploneorg/kudobounty/setuphandlers.py

@@ -42 +42 @@
             wftool.doActionFor(topic, 'publish')
         
-        logger.info("Bounty submissions aggregator successfully added")
-
+        logger.info("Bounty submissions aggregator added")
+    else:
+        logger.info("Bounty submissions aggregator already exist at %s" % \
+                    topic.absolute_url())
 
 def createPFGForm(context, container, wftool, logger):
@@ -49 +51 @@
     """
     form = getattr(container, FORM_ID, None)
-    if form is not None:
-        container.manage_delObjects(ids = FORM_ID)
-    # Create new form object
-    container.invokeFactory(id=FORM_ID, type_name="FormFolder",
-                           title="Bounty Submission Form")
-    form = getattr(container, FORM_ID)
-    # cleanup form and import data from the archive
-    form.manage_delObjects(ids=form.objectIds())
-    pfg_data = context.readDataFile("submissions-form.tar.gz")
-    ctx = TarballImportContext(form, pfg_data)
-    IFilesystemImporter(form).import_(ctx, 'structure', True)
-    # Fix importing PFG via GS bug
-    #   - it adds extra indentation, wchich breaks the script.
-    create_bounty_script = form["create-bounty-submission"]
-    create_bounty_script.setScriptBody(CREATE_SCRIPT_BODY)
-    # Update and pubhish the form
-    form.update(**{"actionAdapter":["create-bounty-submission",],})
-    form.unmarkCreationFlag()
-    form.reindexObject()
-    if wftool.getInfoFor(form, 'review_state') != 'published':
-        wftool.doActionFor(form, 'publish')
-    logger.info("Bounty submission form successfully created") 
+    if form is None:
+        container.invokeFactory(id=FORM_ID, type_name="FormFolder",
+                               title="Bounty Submission Form")
+        form = getattr(container, FORM_ID)
+        # cleanup form and import data from the archive
+        form.manage_delObjects(ids=form.objectIds())
+        pfg_data = context.readDataFile("submissions-form.tar.gz")
+        ctx = TarballImportContext(form, pfg_data)
+        IFilesystemImporter(form).import_(ctx, 'structure', True)
+        # Fix importing PFG via GS bug
+        #   - it adds extra indentation, wchich breaks the script.
+        create_bounty_script = form["create-bounty-submission"]
+        create_bounty_script.setScriptBody(CREATE_SCRIPT_BODY)
+        # Update and pubhish the form
+        form.update(**{"actionAdapter":["create-bounty-submission",],})
+        form.unmarkCreationFlag()
+        form.reindexObject()
+        if wftool.getInfoFor(form, 'review_state') != 'published':
+            wftool.doActionFor(form, 'publish')
+        logger.info("Bounty submission form created") 
+    else:
+        logger.info("Bounty submissions form already exist at %s" % \
+                    form.absolute_url())
 
 def createStructure(context, logger):
@@ -77 +80 @@
 
     # CONTAINER
-    if  CONTAINER_ID not in site.objectIds():
+    folder = getattr(site, CONTAINER_ID, None)
+    if  folder is None:
         _createObjectByType('Folder', site, id=CONTAINER_ID,
                             title=CONTAINER_TITLE)
@@ -92 +96 @@
 
         logger.info("Submissions container added")
+    else:
+        logger.info("Submissions container already exist at %s" % \
+                    folder.absolute_url())
 
     createTopic(folder, wftool, logger)