Changeset 3119 in products

Timestamp:

Apr 14, 2011 6:09:56 PM (13 years ago)

Author:

kroman0

Message:

Pyflakes and pep8 fixes #6

Location:

quintagroup.plonecomments/trunk/quintagroup/plonecomments

Files:

• Extensions/Install.py (modified) (2 diffs)
• tests/config.py (modified) (1 diff)
• tests/helperNotify.py (modified) (1 diff)
• tests/testQPloneCommentsCommenting.py (modified) (1 diff)
• tests/testQPloneCommentsNotification.py (modified) (1 diff)
• tests/testQPloneCommentsPermission.py (modified) (1 diff)
• utils.py (modified) (7 diffs)

quintagroup.plonecomments/trunk/quintagroup/plonecomments/Extensions/Install.py

@@ -5 +5 @@
     out = StringIO()
     setup_tool = getToolByName(self, 'portal_setup')
-    setup_tool.runAllImportStepsFromProfile('profile-quintagroup.plonecomments:default')
+    profile = 'profile-quintagroup.plonecomments:default'
+    setup_tool.runAllImportStepsFromProfile(profile)
     print >> out, "Imported install profile."
     return out.getvalue()
@@ -12 +13 @@
     out = StringIO()
     setup_tool = getToolByName(self, 'portal_setup')
-    setup_tool.runAllImportStepsFromProfile('profile-quintagroup.plonecomments:uninstall')
+    profile = 'profile-quintagroup.plonecomments:uninstall'
+    setup_tool.runAllImportStepsFromProfile(profile)
     print >> out, "Imported uninstall profile."
     return out.getvalue()

quintagroup.plonecomments/trunk/quintagroup/plonecomments/tests/config.py

@@ -17 +17 @@
 PERM_NAME = 'Moderate Discussion'
 USERS = {  # Common Members
-         'admin':{'passw': 'secret_admin', 'roles': ['Manager']},
-         'owner':{'passw': 'secret_owner', 'roles': ['Owner']},
-         'member':{'passw': 'secret_member', 'roles': ['Member']},
-         'reviewer':{'passw': 'secret_reviewer', 'roles': ['Reviewer']},
+         'admin': {'passw': 'secret_admin', 'roles': ['Manager']},
+         'owner': {'passw': 'secret_owner', 'roles': ['Owner']},
+         'member': {'passw': 'secret_member', 'roles': ['Member']},
+         'reviewer': {'passw': 'secret_reviewer', 'roles': ['Reviewer']},
            # Members for discussion manager group
-         'dm_admin':{'passw': 'secret_dm_admin', 'roles': ['Manager']},
-         'dm_owner':{'passw': 'secret_dm_owner', 'roles': ['Owner']},
-         'dm_member':{'passw': 'secret_dm_member', 'roles': ['Member']},
-         'dm_reviewer':{'passw': 'secret_dm_reviewer', 'roles': ['Reviewer']},
+         'dm_admin': {'passw': 'secret_dm_admin', 'roles': ['Manager']},
+         'dm_owner': {'passw': 'secret_dm_owner', 'roles': ['Owner']},
+         'dm_member': {'passw': 'secret_dm_member', 'roles': ['Member']},
+         'dm_reviewer': {'passw': 'secret_dm_reviewer', 'roles': ['Reviewer']},
         }
 COMMON_USERS_IDS = [u for u in USERS.keys() if not u.startswith('dm_')]

quintagroup.plonecomments/trunk/quintagroup/plonecomments/tests/helperNotify.py

@@ -14 +14 @@
 def testMailExistance(sel):
     mailhost = sel.portal.MailHost
-    if mailhost.messages: 
+    if mailhost.messages:
         return True
     return False

quintagroup.plonecomments/trunk/quintagroup/plonecomments/tests/testQPloneCommentsCommenting.py

@@ -70 +70 @@
         self.login('dm_admin')
         replies_after = len(self.discussion.getDiscussionFor(doc_obj).getReplies())
-        self.failUnless(replies_after-replies_before,
+        self.failUnless(replies_after - replies_before,
             "Anonymous user CAN'T really add comment in terned ON *Anonymous commenting mode*.")
 

quintagroup.plonecomments/trunk/quintagroup/plonecomments/tests/testQPloneCommentsNotification.py

@@ -49 +49 @@
 
         # Add Manager user - 'dm' and add him to Discussion Manager group
-        self.portal.portal_membership.addMember('dm', 'secret' , ['Manager'], [])
+        self.portal.portal_membership.addMember('dm', 'secret', ['Manager'], [])
         portal_groups = getToolByName(self.portal, 'portal_groups')
         dm_group = portal_groups.getGroupById('DiscussionManager')

quintagroup.plonecomments/trunk/quintagroup/plonecomments/tests/testQPloneCommentsPermission.py

@@ -13 +13 @@
 
     def test_install_moderate_discussion_permission(self):
-        roles = [item['name'] for item in self.portal.rolesOfPermission(PERM_NAME) if item['selected'] == 'SELECTED']
-        self.failUnless( roles != [], '%s not installed'%PERM_NAME)
+        roles = [item['name']
+                 for item in self.portal.rolesOfPermission(PERM_NAME)
+                 if item['selected'] == 'SELECTED']
+        self.failUnless(roles != [], '%s not installed' % PERM_NAME)
 
     def test_deleteReply_permission(self):

quintagroup.plonecomments/trunk/quintagroup/plonecomments/utils.py

@@ -4 +4 @@
 from Products.CMFCore.utils import getToolByName
 from Products.CMFPlone.utils import safe_unicode
+
 
 # Get apropriate property from (propery_sheeet) configlet
@@ -14 +15 @@
     return result
 
+
 def publishDiscussion(self):
     roles = ['Anonymous']
@@ -20 +22 @@
     self._p_changed = 1
     self.reindexObject()
+
 
 def setAnonymCommenting(context, allow=False):
@@ -35 +38 @@
             portal.manage_permission('Reply to item', roles, 1)
 
+
 def manage_mails(reply, context, action):
     def sendMails(props, actions, key):
@@ -71 +75 @@
             sendMails(props, actions, 'onAuthenticatedReportAbuse')
 
+
 def getMsg(context, template, args):
     return getattr(context, template)(**args)
+
 
 def allowEmail(context, reply, state, creator):
@@ -79 +85 @@
         condition = condition(reply=reply, state=state, creator=creator)
     return condition
+
 
 def send_email(reply, context, state):
@@ -251 +258 @@
                   'Have you configured an email server for Plone?'))
 
+
 def setStatusMsg(state, context, msg):
     context.plone_utils.addPortalMessage(msg)