Changeset 2927 in products

Timestamp:

Oct 26, 2010 2:33:27 PM (14 years ago)

Author:

mylan

Message:

#233: Reduce catch exceptions to URLError and HTTPError, log error to error_log, return link to error_log

File:

• quintagroup.seoptimizer/trunk/quintagroup/seoptimizer/browser/keywords.py (modified) (4 diffs)

quintagroup.seoptimizer/trunk/quintagroup/seoptimizer/browser/keywords.py

@@ -1 @@
-import re, commands, urllib2
+import re, sys, urllib2
 from xml.dom import Node
 
@@ -35 +35 @@
                                  context=self.context)
         # Get html page internally or with external request
+        error_url = ""
         if isExternal:
             # Not pass timeout option because:
@@ -45 +46 @@
                 finally:
                     'resp' in locals().keys() and resp.close()
-            except Exception:
+            except (urllib2.URLError, urllib2.HTTPError), e:
                 # In case of exceed timeout period or other URL connection errors.
+                info = sys.exc_info()
+                elog = getToolByName(self.context, "error_log")
+                if elog:
+                    error_url = elog.raising(info)
                 html = None
         else:
@@ -60 +65 @@
                 result.append(' - '.join((keyword, keyword_on_page)))
         else:
-            result.append("Problem with page retrieval")
+            sfx = error_url and ", details at %s." % error_url or "."
+            result.append("Problem with page retrieval" + sfx)
 
         return ts.utranslate(domain='quintagroup.seoptimizer',