Changeset 2755 in products

Timestamp:

Aug 17, 2010 12:39:41 PM (14 years ago)

Author:

fenix

Message:

• added tests;
• fixed style bug (None class was added when no portlet style is selected);
• removed trailing characters;
• removed unnecessary pice of code;
• some javascript optimizations;

Location:

quintagroup.portlet.collection/trunk/quintagroup/portlet/collection

Files:

• browser/resources/batch.js (modified) (2 diffs)
• collection.pt (modified) (1 diff)
• tests (added)
• tests/__init__.py (added)
• tests/base.py (added)
• tests/test_portlet.py (added)
• vocabularies.py (modified) (2 diffs)

quintagroup.portlet.collection/trunk/quintagroup/portlet/collection/browser/resources/batch.js

@@ -18 +18 @@
 
     var bind_prev_handler = function(link, index){
-      if (index == 0) {
-        jq(link).hide();
-      }
+      if (index == 0) jq(link).hide();
       jq(link).unbind();
       jq(link).click(function(e) {
@@ -33 +31 @@
     };
     var bind_next_handler = function(link, index){
-      if (index == nav_links.size()-1) {
-        jq(link).hide();
-      }
+      if (index == nav_links.size()-1) jq(link).hide();
       jq(link).unbind();
       jq(link).click(function(e) {

quintagroup.portlet.collection/trunk/quintagroup/portlet/collection/collection.pt

@@ -3 +3 @@
     tal:define="collection_url view/collection_url;
                 styling view/data/styling"
-    tal:attributes="class string:${attrs/class} ${styling}">
+    tal:attributes="class python: styling and '%s %s'% (attrs['class'], styling) or attrs['class']">
 
     <dt class="portletHeader">

quintagroup.portlet.collection/trunk/quintagroup/portlet/collection/vocabularies.py

@@ -21 +21 @@
     implements(IVocabularyFactory)
 
-    
+
     def __call__(self, context):
         styles = getStylesVocabulary(context)
@@ -34 +34 @@
                 value = value.decode(charset)
             items.append(SimpleTerm(value, value, _(title)))
-        return SimpleVocabulary(items)
-
-        items = [SimpleTerm(value, value, title) for value, title in PORTLET_CSS_STYLES]
         return SimpleVocabulary(items)