Changeset 2262 in products

Timestamp:

May 6, 2010 10:04:39 AM (14 years ago)

Author:

crchemist

Message:

refactor seo_context from view to multiadapter

Location:

quintagroup.seoptimizer/branches/3.0.1-cleanup/quintagroup/seoptimizer

Files:

• adapters.py (modified) (2 diffs)
• browser/configure.zcml (modified) (2 diffs)
• browser/interfaces.py (modified) (1 diff)
• browser/templates/seo_context_properties.pt (modified) (1 diff)
• browser/viewlets.py (modified) (4 diffs)
• browser/views.py (modified) (4 diffs)

quintagroup.seoptimizer/branches/3.0.1-cleanup/quintagroup/seoptimizer/adapters.py

@@ -8 +8 @@
 from quintagroup.seoptimizer.interfaces import IMetaKeywords, IMappingMetaTags
 from quintagroup.seoptimizer.browser.seo_configlet import ISEOConfigletSchema
+
+from browser.interfaces import ISEOContext
 
 METADATA_MAPS = dict([
@@ -37 +39 @@
         """
         meta_keywords = []
-        seo_context = queryMultiAdapter((self.context, self.context.REQUEST),
-                                        name='seo_context')
+        seo_context = queryMultiAdapter((self.context, self.context.REQUEST), ISEOContext)
         if seo_context:
             meta_keywords = list(seo_context['meta_keywords'])

quintagroup.seoptimizer/branches/3.0.1-cleanup/quintagroup/seoptimizer/browser/configure.zcml

@@ -64 +64 @@
 
     <browser:page
-        name="seo_context"
-        for="*"
-        class=".views.SEOContext"
-        layer=".interfaces.IPloneSEOLayer"
-        permission="zope2.View"
-        />
-
-    <browser:page
         name="seo-context-properties"
         for="*"
@@ -82 +74 @@
     <browser:resourceDirectory name="quintagroup.seoptimizer" directory="./resources" />
 
+  <!--Adapters-->
+  <adapter
+      for="*
+           zope.publisher.interfaces.browser.IBrowserRequest"
+      factory=".views.SEOContext"/>
+
 </configure>

quintagroup.seoptimizer/branches/3.0.1-cleanup/quintagroup/seoptimizer/browser/interfaces.py

@@ -14 +14 @@
             2. Parse *text* and validate each extracted keyword
                for appearing on the context page """
+
+class ISEOContext(Interface):
+    """
+    """
+

quintagroup.seoptimizer/branches/3.0.1-cleanup/quintagroup/seoptimizer/browser/templates/seo_context_properties.pt

@@ -30 +30 @@
                     Iterator python:modules['Products.CMFPlone'].IndexIterator;
                     tabindex python:Iterator(mainSlot=False);
-                    seo_context here/@@seo_context"><!--TODO:implement validation and errors handling-->
+                    seo_context view/seo_context"><!--TODO:implement validation and errors handling-->
       <h1 i18n:translate="heading_edit_seo_properties">Edit SEO Properties</h1>
       <div class="documentDescription" i18n:translate="description_edit_seo_properties">

quintagroup.seoptimizer/branches/3.0.1-cleanup/quintagroup/seoptimizer/browser/viewlets.py

@@ -16 +16 @@
 
 from Products.CMFPlone.PloneTool import *
+
+from interfaces import ISEOContext
 
 class SEOTagsViewlet( ViewletBase ):
@@ -34 +36 @@
         pps = queryMultiAdapter((self.context, self.request), name="plone_portal_state")
         seo_global = queryAdapter(pps.portal(), ISEOConfigletSchema)
-        seo_context = queryMultiAdapter((self.context, self.request), name='seo_context')
+        seo_context = queryMultiAdapter((self.context, self.request), ISEOContext)
 
         use_all = seo_global.exposeDCMetaTags
@@ -151 +153 @@
         self.context_state = getMultiAdapter((self.context, self.request),
                                              name=u'plone_context_state')
-        self.seo_context = getMultiAdapter((self.context, self.request),
-                                             name=u'seo_context')
+        self.seo_context = getMultiAdapter((self.context, self.request), ISEOContext)
 
         self.override_title = self.seo_context['has_seo_title']
@@ -206 +207 @@
     """
     def render( self ):
-        seoc = getMultiAdapter((self.context, self.request), name=u'seo_context')
+        seoc = getMultiAdapter((self.context, self.request), ISEOContext)
         if seoc['seo_canonical']:
             return """<link rel="canonical" href="%s" />""" % seoc['seo_canonical']

quintagroup.seoptimizer/branches/3.0.1-cleanup/quintagroup/seoptimizer/browser/views.py

@@ -1 +1 @@
 from time import time
+
 from DateTime import DateTime
 from Acquisition import aq_inner
 from zope.component import queryAdapter
 from zope.component import queryMultiAdapter
+from zope.component import adapts
+from zope.interface import implements
 from zope.schema.interfaces import InvalidValue
-
 from plone.memoize import view, ram
 
@@ -17 +19 @@
 from quintagroup.seoptimizer.browser.seo_configlet import ISEOConfigletSchema
 from quintagroup.seoptimizer import SeoptimizerMessageFactory as _
+
+from interfaces import ISEOContext
 
 SEPERATOR = '|'
@@ -28 +32 @@
     return (self.pps.portal(), time() // (60 * 60))
 
-class SEOContext( BrowserView ):
+class SEOContext(object):
     """ This class contains methods that allows to edit html header meta tags.
     """
-
-    def __init__(self, *args, **kwargs):
-        super(SEOContext, self).__init__(*args, **kwargs)
-        self.pps = queryMultiAdapter((self.context, self.request), name="plone_portal_state")
-        self.pcs = queryMultiAdapter((self.context, self.request), name="plone_context_state")
+    implements(ISEOContext)
+
+    def __init__(self, context, request):
+        self.context, self.request = context, request
+        self.pps = queryMultiAdapter((context, request), name="plone_portal_state")
+        self.pcs = queryMultiAdapter((context, request), name="plone_context_state")
         self.gseo = queryAdapter(self.pps.portal(), ISEOConfigletSchema)
         self._seotags = self._getSEOTags()
@@ -171 +176 @@
         """
         return ''
+
+    def seo_context(self):
+        return queryMultiAdapter((self.context, self.request), ISEOContext)
 
     def setProperty(self, property, value, type='string'):