Changeset 226

Show
Ignore:
Timestamp:
01/31/06 11:19:05
Author:
mylan
Message:

- Cleaned and equalized patch.py & utils.py with Plone 2.1.2 version
- Update moderation test.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • qPloneComments/trunk/patch.py

    r225 r226  
    1 from Products.CMFCore.CMFCorePermissions import View, ReviewPortalContent,DeleteObjects 
    21from Products.CMFDefault.DiscussionItem import DiscussionItemContainer, DiscussionItem 
    32from AccessControl import getSecurityManager, Unauthorized 
     
    4746    if ifModerate: 
    4847        roles = ['DiscussionManager'] 
    49         item.manage_permission(DeleteObjects, roles, acquire=1) 
    50         #item.manage_permission(ReviewPortalContent, roles, acquire=0) 
    51         item.manage_permission(View, roles, acquire=0) 
     48        item.manage_permission('Delete objects', roles, acquire=1) 
     49        #item.manage_permission('Review portal content', roles, acquire=0) 
     50        item.manage_permission('View', roles, acquire=0) 
    5251    else: 
    5352        item.review_state = "published" 
     
    7675    return objects 
    7776 
    78 #DiscussionItemContainer.__dict__["createReply"] =  createReply 
    79 #DiscussionItemContainer.__dict__["getReplies"] =  getReplies 
     77 
    8078DiscussionItemContainer.createReply = createReply 
    8179DiscussionItemContainer.getReplies = getReplies 
  • qPloneComments/trunk/tests/testQPloneCommentsModeration.py

    r225 r226  
    149149 
    150150 
    151     def __testPublishing(self): 
    152         # Check whether perform real publishing 
    153         for u in DM_USERS_IDS: 
    154             doc_id = "doc_%s" % u 
    155             doc_obj = getattr(self.portal, doc_id) 
    156             getReplies = self.discussion.getDiscussionFor(doc_obj).getReplies 
    157             # Check whether anonymous get no reply 
    158             self.logout() 
    159             self.assert_(not getReplies(), "View not published reply ALLOW for Anonymous") 
    160             # Login with actual (tested) user with DiscussionManager role and publish discussion 
    161             self.login(u) 
    162             self.assert_(getReplies(), "%s - member of DiscussionManager group NOT VIEW not published reply" % u) 
    163             getReplies()[0].discussion_publish_comment() 
    164             # Check whether Anonym view published reply 
    165             self.logout() 
    166             self.assert_(getReplies(), "%s - member of DiscussionManager group NOT PUBLISH reply" % u) 
    167  
    168  
    169151    def testPublishing(self): 
    170152        # Check whether perform real publishing 
  • qPloneComments/trunk/utils.py

    r225 r226  
    11from Products.CMFCore.utils import getToolByName 
    2 from Products.CMFCore.CMFCorePermissions import ReplyToItem 
    3 from Products.qPloneComments.config import * 
     2from config import * 
    43 
    54# Get apropriate property from (propery_sheeet) configlet 
     
    1716def send_email(reply, context, state="approve"): 
    1817    # Check is notification active 
    19     send_result = 0 
    2018    notify = False 
    2119    if state=="approve": 
     
    2422        notify = getProp(context, "Enable_Published_Notification", False) 
    2523    if not notify: 
    26         return send_result 
     24        return 0 
    2725 
    2826    # Get parent object 
     
    6361                           mfrom=from_address, organization_name=organization_name) 
    6462        try: 
    65             host = context.MailHost  
     63            host = context.MailHost 
    6664            host.send( message ) 
    67             send_result = 1 
    6865        except: 
    69             send_result =
    70     return send_result 
     66            return
     67    return 1 
    7168 
    7269         
     
    8178    portal = getToolByName(context, 'portal_url').getPortalObject() 
    8279    if allow: 
    83         portal.manage_permission(ReplyToItem, ['Anonymous','Manager','Member'], 1) 
     80        portal.manage_permission('Reply to item', ['Anonymous','Manager','Member'], 1) 
    8481    else: 
    85         portal.manage_permission(ReplyToItem, ['Manager','Member'], 1) 
     82        portal.manage_permission('Reply to item', ['Manager','Member'], 1) 
    8683 
    87      
     84