Changeset 1740 in products

Timestamp:

Feb 15, 2010 3:44:40 PM (14 years ago)

Author:

koval

Message:

fixed buggy code in Install.py and removed unnecessary types.xml file

Location:

quintagroup.seoptimizer/trunk/quintagroup/seoptimizer

Files:

• Extensions/Install.py (modified) (1 diff)
• profiles/default/skins.xml (modified) (1 diff)
• profiles/default/types.xml (deleted)

quintagroup.seoptimizer/trunk/quintagroup/seoptimizer/Extensions/Install.py

@@ -1 +1 @@
 from Products.CMFCore.utils import getToolByName
+
 from quintagroup.seoptimizer.config import PROJECT_NAME
 
+# our GenericSetup profile names
+INSTALL = 'profile-%s:default' % PROJECT_NAME
+REINSTALL = 'profile-%s:reinstall' % PROJECT_NAME
+UNINSTALL = 'profile-%s:uninstall' % PROJECT_NAME
+
 def install(portal, reinstall=False):
+    """ (Re)Install this product.
+
+        This external method is need, because portal_quickinstaller doens't know
+        what GenericProfile profile to apply when reinstalling a product.
+    """
     setup_tool = getToolByName(portal, 'portal_setup')
-    setup_tool.setBaselineContext('profile-%s:uninstall'%PROJECT_NAME)
     if reinstall:
-        setup_tool.setBaselineContext('profile-%s:reinstall'%PROJECT_NAME)
-        setup_tool.runAllImportStepsFromProfile('profile-%s:reinstall'%PROJECT_NAME)
-        return "Ran reinstall steps."
+        setup_tool.runAllImportStepsFromProfile(REINSTALL)
+        return "Ran all reinstall steps."
     else:
-        setup_tool.setBaselineContext('profile-%s:uninstall'%PROJECT_NAME)
-        setup_tool.runAllImportStepsFromProfile('profile-%s:default'%PROJECT_NAME)
+        setup_tool.runAllImportStepsFromProfile(INSTALL)
         return "Ran all install steps."
 
 def uninstall(portal, reinstall=False):
+    """ Uninstall this product.
+
+        This external method is need, because portal_quickinstaller doens't know
+        what GenericProfile profile to apply when uninstalling a product.
+    """
     setup_tool = getToolByName(portal, 'portal_setup')
-    setup_tool.setBaselineContext('profile-%s:uninstall'%PROJECT_NAME)
     if reinstall:
-        return "Ran reinstall steps."
+        return "Ran all reinstall steps."
     else:
-        setup_tool.runAllImportStepsFromProfile('profile-%s:uninstall'%PROJECT_NAME)
+        setup_tool.runAllImportStepsFromProfile(UNINSTALL)
         return "Ran all uninstall steps."

quintagroup.seoptimizer/trunk/quintagroup/seoptimizer/profiles/default/skins.xml

@@ -3 +3 @@
  <object name="quintagroup.seoptimizer" meta_type="Filesystem Directory View"
     directory="quintagroup.seoptimizer:skins/quintagroup.seoptimizer"/>
-  <skin-path name="*">
+ <skin-path name="*">
   <layer name="quintagroup.seoptimizer" insert-after="custom"/>
  </skin-path>