Changeset 1070

Timestamp:

03/03/08 04:16:18

Author:

piv

Message:

fixed js bug: checked attribute (checkbox) not working in IE

Files:

• qPloneTabs/trunk/HISTORY.txt (modified) (1 diff)
• qPloneTabs/trunk/skins/qPloneTabs/javascripts/qplonetabs.js (modified) (5 diffs)
• qPloneTabs/trunk/skins/qPloneTabs/qpt_gettabslist.pt (modified) (2 diffs)
• qPloneTabs/trunk/version.txt (modified) (1 diff)

qPloneTabs/trunk/HISTORY.txt

@@ +1 @@
+0.3.1
+
+  * fixed js bug: after cancel of sort action innerHTML return not actual data for updating action to previous state,
+                  now instead of innerHTML property used DOM creation of actions list
+
+  * fixed css bug: when action's url is too long it overlap drag handle on sorting thus disabling drug&drop of this action
+
-0.3.0
-

qPloneTabs/trunk/skins/qPloneTabs/javascripts/qplonetabs.js

@@ -1 +1 @@
-/* Global variables */
-
+var gBeforeReorderData = [];        // storage for actions before sorting
-var gBeforeReorderFragment = null;  // document fragment for insertion in UL after clicking cancel button after reorder
-
+         
-var category = 'portal_tabs';
-
@@ -11 +12 @@
-    el.onclick = function(ev){
-      var ev = ev ? ev : window.event;
-
+
+
+
+
+
+
+
+
-      shiftClassNames('app', 'viewing', 'sorting');
-      Sortable.create('tabslist', {handle: 'drag-handle'});
@@ -50 +58 @@
-      Sortable.destroy('tabslist');
-      shiftClassNames('app', 'sorting', 'viewing');
-
+
+
+
+
+
+
+
+
+
-      el.attachEvent ? ieHover() : '';
-      Behaviour.apply();
@@ -316 +332 @@
-    };
-});
-
+
+
+
+
+
+
-
-if (window.attachEvent) {Event.observe(window, 'load', ieHover, false);}
@@ -377 +398 @@
-  $A($(el).getElementsByTagName('LI')).each(function(li,idx){if(li != el) li.onclick=function(event){return false;};});
-};
+
+
+//**********************************************
+
+//    Fixed bug: innerHTML return not actual data, now used DOM
+
+
+function grepInfo(li) {
+    
+    // grep li state
+    var info = {"li.id" : li.id, "li.title": li.title, "li.className" : li.className};
+    
+    // grep visibility checkbox state
+    var vis_box = li.getElementsByTagName("INPUT")[0];
+    info["vis_box.checked"] = vis_box.checked;
+    info["vis_box.name"] = vis_box.name;
+    
+    var spans = li.getElementsByTagName("SPAN");
+    
+    // grep url helper state
+    info["url_helper.text"] = spans[0].innerHTML;
+    
+    // grep tab title state
+    info["tab_title.text"] = spans[1].innerHTML;
+    
+    // grep edit form state
+    var edit_form = li.getElementsByTagName("FORM")[0];
+    info["edit_form.name"] = edit_form.name;
+    info["edit_form.action"] = edit_form.action;
+    
+    var inputs = edit_form.getElementsByTagName("INPUT");
+    
+    // grep hidden input index value
+    info["input_idx.value"] = inputs[0].value;
+    
+    // grep action name input state
+    info["input_name.name"] = inputs[1].name;
+    info["input_name.value"] = inputs[1].value;
+    
+    // grep dl advanced section class name
+    info["dl_advanced.className"] = edit_form.getElementsByTagName("DL")[1].className;
+    info["dd_advanced.style.display"] = edit_form.getElementsByTagName("DD")[1].style.display;
+    
+    // grep url input state
+    info["input_url.name"] = inputs[2].name;
+    info["input_url.value"] = inputs[2].value;
+    
+    // grep id input state
+    info["input_id.name"] = inputs[3].name;
+    info["input_id.value"] = inputs[3].value;
+    
+    // grep condition input state
+    info["input_condition.name"] = inputs[4].name;
+    info["input_condition.value"] = inputs[4].value;
+    
+    // grep buttons state
+    info["save_button.value"] = inputs[5].value;
+    info["cancel_button.value"] = inputs[6].value;
+    
+    return info;
+}
+
+function recoverAction(info) {
+    
+    // create list item and assign corresponding attributes
+    var li = document.createElement("LI");
+    li.id = info["li.id"];
+    li.title = info["li.title"];
+    li.className = info["li.className"];
+    
+    // create drag handle image and assign corresponding attributes
+    var drag_handle = document.createElement("IMG");
+    drag_handle.className = "drag-handle";
+    drag_handle.src = "drag.gif";
+    drag_handle.alt = "";
+    drag_handle.height = "11";
+    drag_handle.width = "25";
+    
+    li.appendChild(drag_handle);
+    
+    // create bridge div element for visibility checkbox
+    var bridge = document.createElement("DIV");
+    bridge.className = "bridge";
+    
+    // create checkbox for visibility control
+    var vis_box = document.createElement("INPUT");
+    vis_box.type = "checkbox";
+    vis_box.className = "visibility";
+    vis_box.value = "1";
+    vis_box.title = "visibility";
+    vis_box.name = info["vis_box.name"];
+    
+    bridge.appendChild(vis_box);
+
+    // buggy IE
+    if (info["vis_box.checked"]) {
+        vis_box.setAttribute("checked", "checked");
+        vis_box.defaultChecked = true;
+    }
+
+    li.appendChild(bridge);
+    
+    // create Delete link
+    var del_link = document.createElement("A");
+    del_link.className = "delete";
+    del_link.href = "#";
+    del_link.appendChild(document.createTextNode("Delete"));
+    
+    li.appendChild(del_link);
+    
+    // create url-helper element
+    var url_helper = document.createElement("SPAN");
+    url_helper.className = "url-helper";
+    url_helper.appendChild(document.createTextNode(info["url_helper.text"]));
+    
+    li.appendChild(url_helper);
+    
+    // create tab title element
+    var tab_title = document.createElement("SPAN");
+    tab_title.className = "tab-title";
+    tab_title.appendChild(document.createTextNode(info["tab_title.text"]));
+    
+    li.appendChild(tab_title);
+    
+    // create edit form
+    var edit_form = document.createElement("FORM");
+    edit_form.className = "editform";
+    edit_form.method = "post";
+    edit_form.name = info["edit_form.name"];
+    edit_form.action = info["edit_form.action"];
+    
+    // create hidden input with index value
+    var input_idx = document.createElement("INPUT");
+    input_idx.type = "hidden";
+    input_idx.name = "idx";
+    input_idx.value = info["input_idx.value"];
+    
+    edit_form.appendChild(input_idx);
+    
+    // create dl element for name input section
+    var dl_name = document.createElement("DL");
+    var dt_name = document.createElement("DT");
+    var name_label = document.createElement("LABEL");
+    name_label.appendChild(document.createTextNode("Name"));
+    
+    dt_name.appendChild(name_label);
+    dl_name.appendChild(dt_name);
+    
+    // crete input for action name
+    var dd_name = document.createElement("DD");
+    var input_name = document.createElement("INPUT");
+    input_name.type = "text";
+    input_name.size = "30";
+    input_name.name = info["input_name.name"];
+    input_name.value = info["input_name.value"];
+    
+    dd_name.appendChild(input_name);
+    dl_name.appendChild(dd_name);
+    edit_form.appendChild(dl_name);
+    
+    // create dl element for advanced inputs
+    var dl_advanced = document.createElement("DL");
+    dl_advanced.className = info["dl_advanced.className"];
+    
+    // create collapsible header
+    var dt_advanced = document.createElement("DT");
+    dt_advanced.className = "headerAdvanced";
+    dt_advanced.appendChild(document.createTextNode("Advanced"));
+    
+    dl_advanced.appendChild(dt_advanced);
+    
+    // create collapsible content
+    var dd_advanced = document.createElement("DD");
+    dd_advanced.className = "contentAdvanced";
+    dd_advanced.style.display = info["dd_advanced.style.display"];
+    
+    // add URL section
+    // add url header
+    var dl_url = document.createElement("DL");
+    var dt_url = document.createElement("DT");
+    var label_url = document.createElement("LABEL");
+    label_url.appendChild(document.createTextNode("URL (Expression)"));
+    
+    dt_url.appendChild(label_url);
+    dl_url.appendChild(dt_url);
+    
+    //add url value
+    var dd_url = document.createElement("DD");
+    var input_url = document.createElement("INPUT");
+    input_url.type = "text";
+    input_url.size = "30";
+    input_url.name = info["input_url.name"];
+    input_url.value = info["input_url.value"];
+    
+    dd_url.appendChild(input_url);
+    dl_url.appendChild(dd_url);
+    dd_advanced.appendChild(dl_url);
+    
+    // add ID section
+    // add id header
+    var dl_id = document.createElement("DL");
+    var dt_id = document.createElement("DT");
+    var label_id = document.createElement("LABEL");
+    label_id.appendChild(document.createTextNode("Id"));
+    
+    dt_id.appendChild(label_id);
+    dl_id.appendChild(dt_id);
+    
+    //add id value
+    var dd_id = document.createElement("DD");
+    var input_id = document.createElement("INPUT");
+    input_id.type = "text";
+    input_id.name = info["input_id.name"];
+    input_id.value = info["input_id.value"];
+    
+    dd_id.appendChild(input_id);
+    dl_id.appendChild(dd_id);
+    dd_advanced.appendChild(dl_id);
+    
+    // add Condition section
+    // add condition header
+    var dl_condition = document.createElement("DL");
+    var dt_condition = document.createElement("DT");
+    var label_condition = document.createElement("LABEL");
+    label_condition.appendChild(document.createTextNode("Condition (Expression)"));
+    
+    dt_condition.appendChild(label_condition);
+    dl_condition.appendChild(dt_condition);
+    
+    //add condition value
+    var dd_condition = document.createElement("DD");
+    var input_condition = document.createElement("INPUT");
+    input_condition.type = "text";
+    input_condition.size = "30";
+    input_condition.name = info["input_condition.name"];
+    input_condition.value = info["input_condition.value"];
+    
+    dd_condition.appendChild(input_condition);
+    dl_condition.appendChild(dd_condition);
+    dd_advanced.appendChild(dl_condition);
+    
+    // add visual clear div to advanced dd element
+    var visual_clear = document.createElement("DIV");
+    visual_clear.className = "visualClear";
+    visual_clear.appendChild = document.createTextNode("<!-- -->");
+    
+    dd_advanced.appendChild(visual_clear);
+    dl_advanced.appendChild(dd_advanced);
+    edit_form.appendChild(dl_advanced);
+    
+    // create div element for form controls
+    var form_controls = document.createElement("DIV");
+    
+    // add save button
+    var save_button = document.createElement("INPUT");
+    save_button.type = "submit";
+    save_button.className = "editsave";
+    save_button.value = info["save_button.value"];
+    form_controls.appendChild(save_button);
+    
+    // add cancel button
+    var cancel_button = document.createElement("INPUT");
+    cancel_button.type = "submit";
+    cancel_button.className = "editcancel";
+    cancel_button.value = info["cancel_button.value"];
+    form_controls.appendChild(cancel_button);
+    
+    edit_form.appendChild(form_controls);
+    li.appendChild(edit_form);
+
+    return li;
+}

qPloneTabs/trunk/skins/qPloneTabs/qpt_gettabslist.pt

@@ -20 +20 @@
-        tal:attributes="action string:${here/portal_url}/prefs_tabs_form;
-                        name string:f$index">
-
+  
-      <dl>
-        <dt><label>Name</label></dt>
@@ -51 +51 @@
-        </dd>
-      </dl>
-
-
-
-
+  
+  
+  
+  
-  </form>
-</li>

qPloneTabs/trunk/version.txt

@@ -1 @@
-0
+1